Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Setting for Acknowledgment Display in Card Details #7360

Closed
freddidierRTE opened this issue Oct 10, 2024 · 0 comments · Fixed by #7381
Closed

User Setting for Acknowledgment Display in Card Details #7360

freddidierRTE opened this issue Oct 10, 2024 · 0 comments · Fixed by #7381
Assignees
Labels
Enhancement New feature

Comments

@freddidierRTE
Copy link
Contributor

freddidierRTE commented Oct 10, 2024

The option is to be add in the user settings :

In english : Always show acknowlegmentq in cards details
In french : Toujours afficher les acquittements dans le detail des cartes

The option should not be set by default

As always for settings , option could be hidden via web-ui configuration

There is already an option in the state defintion regarding this topic : showAcknowledgmentFooter

The rules is :

  • if showAcknowledgmentFooter is set to Never , it is not displayed even if user set the option in the settings
  • for all other values for showAcknowledgmentFooter, it is displayed if user set the option in the settings

Modify documentation accordingly : https://opfab.github.io/documentation/current/reference_doc/#_displaying_the_entities_acknowledgments

Implementation :

The fact that the ack are visible is today computed via displayCardAcknowledgedFooter() in card-body.component.ts that itself calls isUserAuthorizedToSeeAcknowledgmentFooter in UserPermissionsService

Do develop this issue the idea is to refacto this part and to add unit test .

To do that create a view card-body.view.ts that contains for now one method : isCardAcknowlegedFooterVisible(userperimeter , card) . This class could in the future implements other business rules from card-body.component.ts

The class should do the job of the actual method displayCardAcknowledgedFooter and isUserAuthorizedToSeeAcknowledgmentFooter

It should be located in src/app/business/view/card and it should be unit tested (this will avoid a new cypress test for this feature)

@freddidierRTE freddidierRTE added the Enhancement New feature label Oct 10, 2024
@quinarygio quinarygio self-assigned this Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in OperatorFabric Release 4.5.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature
Projects
No open projects
Status: Done
2 participants