-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Setting for Acknowledgment Display in Card Details #7360
Labels
Enhancement
New feature
Comments
quinarygio
added a commit
that referenced
this issue
Oct 14, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
added a commit
that referenced
this issue
Oct 16, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
added a commit
that referenced
this issue
Oct 16, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
added a commit
that referenced
this issue
Oct 16, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
added a commit
that referenced
this issue
Oct 17, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
quinarygio
added a commit
that referenced
this issue
Oct 17, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
freddidierRTE
pushed a commit
that referenced
this issue
Oct 18, 2024
…7360) Signed-off-by: Giovanni Ferrari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The option is to be add in the user settings :
In english : Always show acknowlegmentq in cards details
In french : Toujours afficher les acquittements dans le detail des cartes
The option should not be set by default
As always for settings , option could be hidden via web-ui configuration
There is already an option in the state defintion regarding this topic : showAcknowledgmentFooter
The rules is :
Modify documentation accordingly : https://opfab.github.io/documentation/current/reference_doc/#_displaying_the_entities_acknowledgments
Implementation :
The fact that the ack are visible is today computed via displayCardAcknowledgedFooter() in card-body.component.ts that itself calls isUserAuthorizedToSeeAcknowledgmentFooter in UserPermissionsService
Do develop this issue the idea is to refacto this part and to add unit test .
To do that create a view card-body.view.ts that contains for now one method : isCardAcknowlegedFooterVisible(userperimeter , card) . This class could in the future implements other business rules from card-body.component.ts
The class should do the job of the actual method displayCardAcknowledgedFooter and isUserAuthorizedToSeeAcknowledgmentFooter
It should be located in src/app/business/view/card and it should be unit tested (this will avoid a new cypress test for this feature)
The text was updated successfully, but these errors were encountered: