fix: Updated the CSS file path generation logic in prodExposePlugin t… #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o correctly handle the base URL.
Jiannan-dev
reviewed
Jan 12, 2025
| const href = [baseUrl, assetsDir, cssPath].filter(Boolean).join('/'); | ||
| let href = '' | ||
| const baseUrl = base || curUrl | ||
| console.log(baseUrl) |
There was a problem hiding this comment.
Is this console.log necessary?
There was a problem hiding this comment.
Sorry, it was left from debugging. I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o correctly handle the base URL.
Description
This PR fixes a bug introduced in the previous PR , where the CSS file paths were not correctly handled when the Vite base configuration was not used. The current PR addresses this by ensuring proper handling of the base URL for CSS files.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).