Skip to content

Fix bug on expose-production.ts #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Conversation

frtGoncalo
Copy link
Contributor

@frtGoncalo frtGoncalo commented Feb 21, 2025

Fix bug when exposing the styles to the window

Description

Fixing bug caused on the 1.3.7 release that broke the dontAppendStylesToHead flag when set to true

Additional context

When running dynamicLoadingCss throws error saying cannot read name of undefined;
To test just run Module with dontAppendStylesToHead, set to true in the current version(1.3.9) the error happens


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Code of Conduct and follow the Commit Convention guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Fix bug when exposing the styles to the window
@Jiannan-dev
Copy link
Collaborator

Thanks

@Jiannan-dev Jiannan-dev merged commit be78ec0 into originjs:main Mar 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants