pinning versions, so things wont break orum #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneslumpe
previously approved these changes
Feb 10, 2025
| @@ -40,16 +40,16 @@ | |||
| "webpack-dev-server": "^4.7.3" | |||
| }, | |||
| "dependencies": { | |||
| "@types/ws": "^8.5.0", | |||
There was a problem hiding this comment.
It looks like this type was resolved to `version "8.5.13" in the orum repo previously? (You can see in this diff which types get removed when you bump the purview version to this branch)
There was a problem hiding this comment.
forced that version, but downgraded csstype to 3.0.9 as purview build didnt work with newer version :|
clifforum
force-pushed
the
forced_versions
branch
from
e7126cc to
3e7329a
Compare
johanneslumpe
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinning versions to avoid breaking orum code.