Skip to content

Remove uncovered as unused asset_list call #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2018
Merged

Remove uncovered as unused asset_list call #1675

merged 1 commit into from
Jun 3, 2018
+0 −49

Conversation

coolo
Copy link
Contributor

@coolo coolo commented May 30, 2018

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2018 •
edited
Loading

Codecov Report

Merging #1675 into master will increase coverage by 5.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
+ Coverage   83.17%   89.03%   +5.86%     
==========================================
  Files         131      131              
  Lines        9393     9379      -14     
==========================================
+ Hits         7813     8351     +538     
+ Misses       1580     1028     -552
Impacted Files Coverage Δ
lib/OpenQA/Resource/Jobs.pm 100% <ø> (+5.26%) ⬆️
lib/OpenQA/ResourceAllocator.pm 83.33% <ø> (+5.02%) ⬆️
lib/OpenQA/WebAPI/Plugin/Helpers.pm 94.28% <0%> (+0.57%) ⬆️
lib/OpenQA/Scheduler/Scheduler.pm 89.06% <0%> (+0.78%) ⬆️
lib/OpenQA/Worker/Common.pm 80.86% <0%> (+1.44%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/Job.pm 85.38% <0%> (+1.53%) ⬆️
lib/OpenQA.pm 71.79% <0%> (+2.56%) ⬆️
lib/OpenQA/Utils.pm 93.44% <0%> (+3.49%) ⬆️
lib/OpenQA/Schema/Result/Jobs.pm 91.64% <0%> (+4.3%) ⬆️
lib/OpenQA/Worker/Pool.pm 91.66% <0%> (+5.55%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eedfb2...691c66e. Read the comment docs.

Martchus
Martchus approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it isn't used anyways, throw it out.

@coolo coolo merged commit e68ebe2 into os-autoinst:master Jun 3, 2018
@coolo coolo deleted the remove_asset_list branch June 3, 2018 07:02
coolo pushed a commit that referenced this pull request Jun 3, 2018
Update documentation to commit e68ebe2
e76f7aa 
commit e68ebe2
Author:     Stephan Kulow <[email protected]>
AuthorDate: Sun Jun 3 09:02:10 2018 +0200
Commit:     GitHub <[email protected]>
CommitDate: Sun Jun 3 09:02:10 2018 +0200

    Remove uncovered as unused asset_list call (#1675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martchus Martchus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coolo @Martchus