Fix bracket for LieSubalgebras (the return value had the wrong type)
#4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: lie theory
release notes: use title
fingolfin
approved these changes
Feb 28, 2025
fingolfin
changed the title
bracket for LieSubalgebrasbracket for LieSubalgebras (it sometimes returned the wrong result)
|
This failed the job "check-consistent-formatting" |
|
I also noticed after merge. IMO this job should either be marked as required (so that automerge doesn't merge things like this) or be removed completely. I think Triage at some point last summer deferred this decision to the PIs. For this current problem, @thofma could you (or literally anybody else) please provide a PR with the fix? The failing log tells the exact things that need to get copy pasted into a REPL. I could probably only do it myself on Tuesday, since I am traveling right now with very limited internet and computer access. |
|
will do |
aaruni96
pushed a commit
that referenced
this pull request
Mar 7, 2025
…esult) (#4676) (cherry picked from commit 94230fd) Signed-off-by: Aaruni Kaushik <[email protected]>
lgoettgens
changed the title
bracket for LieSubalgebras (it sometimes returned the wrong result)bracket for LieSubalgebras (the return value had the wrong type)
fieker
pushed a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @willemdegraaf on slack.