Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include linear solving doc page in the Oscar docs #4701

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Include linear solving doc page in the Oscar docs #4701

merged 2 commits into from
Mar 11, 2025

Conversation

lgoettgens
Copy link
Member

No description provided.

@lgoettgens lgoettgens added documentation Improvements or additions to documentation release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Mar 5, 2025
@lgoettgens lgoettgens requested review from fingolfin and thofma March 5, 2025 13:57
@thofma
Copy link
Collaborator

thofma commented Mar 5, 2025

@joschmitt any concerns?

@lgoettgens
Copy link
Member Author

I am currently working on some patches to the page, since Documenter puts some weird things in there

@joschmitt
Copy link
Member

@joschmitt any concerns?

I don't mind.

I'm on vacation this week. I can review changes next week, if necessary.

@lgoettgens
Copy link
Member Author

See Nemocas/AbstractAlgebra.jl#2022 for the changes to that page

@lgoettgens
Copy link
Member Author

Note that the page is already available via the link in https://docs.oscar-system.org/dev/AbstractAlgebra/matrix/#Linear-solving, but this PR makes it more easily accessible

@lgoettgens
Copy link
Member Author

This now includes a compat bump for Nemocas/AbstractAlgebra.jl#2022.
@thofma @joschmitt could we get this merged?

@lgoettgens lgoettgens added backport 1.3.x backport for release branch 1.3 and removed needs aa update labels Mar 10, 2025
joschmitt
joschmitt approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(I don't think that the module AbstractAlgebra.Solve needs to be mentioned in this file, but that's independent of including it in OSCAR.)

@aaruni96 aaruni96 mentioned this pull request Mar 10, 2025
Merged
10 tasks
@thofma thofma merged commit f694c99 into master Mar 11, 2025
29 of 33 checks passed
@thofma thofma deleted the lg/docs-linear-solving branch March 11, 2025 08:58
aaruni96 pushed a commit that referenced this pull request Mar 12, 2025
@lgoettgens @aaruni96
Include linear solving doc page in the Oscar docs (#4701)
9e60083 
* Include linear solving doc page in the Oscar docs

* Bumb AA compat

(cherry picked from commit f694c99)
Signed-off-by: Aaruni Kaushik <[email protected]>
fieker pushed a commit that referenced this pull request Mar 17, 2025
@lgoettgens @fieker
Include linear solving doc page in the Oscar docs (#4701)
91a1f1b 
* Include linear solving doc page in the Oscar docs

* Bumb AA compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschmitt joschmitt joschmitt approved these changes

@fingolfin fingolfin Awaiting requested review from fingolfin

@thofma thofma Awaiting requested review from thofma

Assignees
No one assigned
Labels
backport 1.3.x backport for release branch 1.3 documentation Improvements or additions to documentation release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgoettgens @thofma @joschmitt