UFF58 header not written

[mdavidsaver]

Since 193d8f6 a change to error if Uff58bExport::writeSpacer() returns zero prevents the header from being written at all since that method always returns zero.

atf-previewer/Uff58bExport.cpp

Line 179 in 892525f

int Uff58bExport::writeSpacer( std::filebuf &fb ) {

atf-previewer/Uff58bExport.cpp

Line 194 in 892525f

return 0;

atf-previewer/Uff58bExport.cpp

Lines 203 to 206 in 892525f

	n = writeSpacer( fb );
	if ( n == 0 ) {
	return ERRINFO(this->mostRecentError,"");
	this->dspErrMsg( this->mostRecentError );

[mdavidsaver]

There is a second issue where the error returned by Uff58bExport::writeHeader() seems to be ignored and no error message is displayed.

[mdavidsaver]

To state the obvious, 193d8f6 was never deployed to SEC.

[gnartohl]

I will look at this tonight. Hard to imagine how I let this happen.

[gnartohl]

I believe I have a fix for this. How do I send the changes?

[mdavidsaver]

I will look at this tonight. Hard to imagine how I let this happen.

I want to reiterate that I think you did a fine job with this application. We both know there will always be bugs. imo. there have been remarkably few given the time pressure we put on you last year.

I believe I have a fix for this. How do I send the changes?

Go ahead and push to the main branch, or let me know if you have difficulties.

[gnartohl]

I am investigating the export errors also. I see the problem. The widget returns a funny value for an end of line that I had not anticipated. Once I get that properly fixed, I will do the push.JohnOn Mar 30, 2025, at 10:05 PM, mdavidsaver ***@***.***> wrote: I will look at this tonight. Hard to imagine how I let this happen. I want to reiterate that I think you did a fine job with this application. We both know there will always be bugs. imo. there have been remarkably few given the time pressure we put on you last year. I believe I have a fix for this. How do I send the changes? Go ahead and push to the main branch, or let me know if you have difficulties.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> mdavidsaver left a comment (osprey-dcs/atf-previewer#3) I will look at this tonight. Hard to imagine how I let this happen. I want to reiterate that I think you did a fine job with this application. We both know there will always be bugs. imo. there have been remarkably few given the time pressure we put on you last year. I believe I have a fix for this. How do I send the changes? Go ahead and push to the main branch, or let me know if you have difficulties. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>