🐛 Fix exception that was thrown when gitlab commits have unmerged PRs #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iated unmerged pull request. Signed-off-by: Keith Ganger <[email protected]>
kgangerlm
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
spencerschrock and
raghavkaul
as code owners
|
Thanks! This code is about to be refactored in #2764. If you would be able to wait for those changes, it will save a little work fixing the merge conflicts later. |
|
Stale pull request message |
kgangerlm
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
==========================================
- Coverage 49.21% 49.20% -0.01%
==========================================
Files 158 158
Lines 11967 11969 +2
==========================================
Hits 5889 5889
- Misses 5709 5711 +2
Partials 369 369 |
|
This is OBE. The issue was fixed with the migration to graphql api. I recommend closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix for #2820
The new gitlab functionality throws an exception from commits.go when there is a merge request associated to the commit, but that merge request is unmerged.
What is the current behavior?
The new gitlab functionality throws an exception from commits.go when there is a merge request associated to the commit, but that merge request is unmerged.
What is the new behavior (if this is a feature change)?**
commits with unmerged PRs are treated as raw commits (as if there were no associated PR)
Which issue(s) this PR fixes
Fixes #2820
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)