Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #16

Merged
merged 3 commits into from
May 16, 2022
Merged

[email protected] #16

merged 3 commits into from
May 16, 2022

Conversation

stainge
Copy link
Contributor

@stainge stainge commented May 15, 2022

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
Could you fix the eslint error? Use suppression comments for one of the warnings.

import { defineAsyncComponent } from "vue"

export default defineClientAppEnhance(({ app }) => {
export default defineClientConfig({
// eslint-disable-next-line @typescript-eslint/naming-convention -- component
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line @typescript-eslint/naming-convention -- component

@stainge
Copy link
Contributor Author

stainge commented May 15, 2022

Thank you for this PR. Could you fix the eslint error? Use suppression comments for one of the warnings.

I have updated clientAppEnhance.ts
I'm not familiar with eslint though

@ota-meshi
Copy link
Owner

Run npm run lint to check with eslint.
Run npm run eslint-fix to fix some of the reports with eslint. This will fix the formatting issue.
If you want to know the details of the command, please look in package.json.

@ota-meshi
Copy link
Owner

If you are using VS Code, I recommend that you install the eslint extension.
https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
You can check in real time on the editor. In addition, this repository is configured to auto-fix reports that can be auto-fixed on the file save.

@stainge
Copy link
Contributor Author

stainge commented May 16, 2022

I have updated index.ts

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit c8119b7 into ota-meshi:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants