Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NODE_TLS_REJECT_UNAUTHORIZED for fetch/install/upgrade/create #4829

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

cirospaciari
Copy link
Member

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@github-actions
Copy link
Contributor

@cirospaciari 3 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bunx.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#0e40d1f90f2d6d5100434cc82ff5e546e71c11e1

@github-actions
Copy link
Contributor

@cirospaciari 6 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/filesink.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#0e40d1f90f2d6d5100434cc82ff5e546e71c11e1

@@ -1679,6 +1683,10 @@ pub const PackageManager = struct {
return this.env.getHttpProxy(url);
}

pub fn tlsRejectUnauthorized(this: *PackageManager) bool {
return this.env.getTLSRejectUnauthorized();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth storing as a property on package_manager since it will be called a large number of times

@Jarred-Sumner Jarred-Sumner merged commit 8615b8a into main Sep 12, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/NODE_TLS_REJECT_UNAUTHORIZED branch September 12, 2023 04:52
@tangoabcdelta
Copy link

tangoabcdelta commented Sep 13, 2023

Awaiting fix for NODE_TLS_REJECT_UNAUTHORIZED: I am running bun install behind a corporate firewall/proxy and the SSL is swapped to inspect the traffic and I don't have the .pem file from our network admins yet. I need to set NODE_TLS_REJECT_UNAUTHORIZED to 0 for installing anything and I will have to set NODE_EXTRA_CA_CERTS to the pem file once I receive it. This fix may help solve that problem.

@Jarred-Sumner
Copy link
Collaborator

@tangoabcdelta this is available in Bun v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants