-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NODE_TLS_REJECT_UNAUTHORIZED for fetch/install/upgrade/create #4829
Conversation
❌ @cirospaciari 3 files with test failures on bun-darwin-aarch64:
|
❌ @cirospaciari 6 files with test failures on bun-darwin-x64-baseline:
|
@@ -1679,6 +1683,10 @@ pub const PackageManager = struct { | |||
return this.env.getHttpProxy(url); | |||
} | |||
|
|||
pub fn tlsRejectUnauthorized(this: *PackageManager) bool { | |||
return this.env.getTLSRejectUnauthorized(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth storing as a property on package_manager since it will be called a large number of times
Awaiting fix for NODE_TLS_REJECT_UNAUTHORIZED: I am running |
@tangoabcdelta this is available in Bun v1.0.1 |
What does this PR do?
How did you verify your code works?
I wrote automated tests