Build broken because of dead link (p4tc)

[antoninbas]

The build keeps failing because this link is dead:

p4c/backends/tc/CMakeLists.txt

Line 42 in 6ad7c9a

URL https://github.com/p4tc-dev/iproute2-p4tc-pub/archive/refs/tags/release-v17-rc6.tar.gz

In particular, this workflow runs on a 4 hour schedule: https://github.com/p4lang/p4c/blob/main/.github/workflows/ci-container-image.yml. So I keep getting a failure notification every 4 hours :/

[ChrisDodd]

Looks like this is from #5011

[fruffy]

@vbnogueira

The problem is that the p4tc testing setup is installed on every build. It should only be used by the p4tc workflow.

[antoninbas]

@fruffy Github workflows have the following behavior for scheduled worklfows:

Notifications for scheduled workflows are sent to the user who last modified the cron syntax in the workflow file.

That user is me, so I get failure notifications every 4h when the build is broken. Any chance you would volunteer to update the cron syntax? BTW, in retrospect, running the workflow every 4h seems a bit excessive, maybe twice a day would be more than enough.

[fruffy]

Currently traveling and do not have my Dev machine available. Can probably fix this on Friday if no other PR resolves it.

…

On March 10, 2025 2:22:25 PM GMT-03:00, Antonin Bas ***@***.***> wrote: antoninbas left a comment (p4lang/p4c#5171) @fruffy Github workflows have the following behavior for scheduled worklfows: > Notifications for scheduled workflows are sent to the user who last modified the cron syntax in the workflow file. That user is me, so I get failure notifications every 4h when the build is broken. Any chance you would volunteer to update the cron syntax? BTW, in retrospect, running the workflow every 4h seems a bit excessive, maybe twice a day would be more than enough. -- Reply to this email directly or view it on GitHub: #5171 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[trvon]

I was able to get the build to working by updating the ./backends/tc/CMakeLists.txt file with the correct sha256 hash and updated version release-v17-rc8. It looks like the old release was deleted.

Here is what the update looks like. I am sure that this can be a simple pull request to master.

  fetchcontent_declare(
    iproute2repo
    URL https://github.com/p4tc-dev/iproute2-p4tc-pub/archive/refs/tags/release-v17-rc8.tar.gz
    URL_HASH SHA256=c96a057cae4054f06a906bb38e7f430cb27c7025cc23bae0943fdc0967c7be29
    SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/runtime/iproute2-p4tc-pub
    USES_TERMINAL_DOWNLOAD TRUE
    GIT_PROGRESS TRUE
    DOWNLOAD_EXTRACT_TIMESTAMP TRUE
  )