Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add p4tc backend to p4testgen #5019

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add p4tc backend to p4testgen #5019

wants to merge 2 commits into from

Conversation

vbnogueira
Copy link
Contributor

First attempt at adding p4testgen support to pna p4tc
Essentially a copy of the pna dpdk version, but with STF output support
Opening as a draft whilst more tests are done

@vbnogueira vbnogueira force-pushed the p4testgen_support_p4tc branch 2 times, most recently from 0efbdc4 to ba430cc Compare November 18, 2024 12:52
@fruffy fruffy self-requested a review November 18, 2024 17:21
@vbnogueira vbnogueira force-pushed the p4testgen_support_p4tc branch from ba430cc to a1a178e Compare November 19, 2024 12:40
@fruffy fruffy added the p4tc Topics related to the P4-TC back end. On PRs, also triggers p4tc CI tests to run. label Nov 20, 2024
@vbnogueira
Add p4tc backend to p4testgen
90b45e9 
Signed-off-by: Victor Nogueira <[email protected]>
@vbnogueira vbnogueira force-pushed the p4testgen_support_p4tc branch from a1a178e to 90b45e9 Compare November 21, 2024 12:45
@fruffy
Copy link
Collaborator

fruffy commented Dec 17, 2024

Is this ready for review or does this depend on #5011?

@vbnogueira vbnogueira marked this pull request as ready for review December 17, 2024 13:37
@vbnogueira
Copy link
Contributor Author

Is this ready for review or does this depend on #5011?

It's ready for review, I removed the draft status

@fruffy
Copy link
Collaborator

fruffy commented Jan 6, 2025

Ideally this should be rebased on #5011 so that we can actually run the tests. What is also missing is the test harness (P4Tests.cmake and TestTemplate.cmake) which run the tests.

Once we run tests on the current TC programs we can see what pieces are missing or mismatched.

@vbnogueira
Copy link
Contributor Author

Ideally this should be rebased on #5011 so that we can actually run the tests. What is also missing is the test harness (P4Tests.cmake and TestTemplate.cmake) which run the tests.

Once we run tests on the current TC programs we can see what pieces are missing or mismatched.

Okk, will do

@fruffy
Copy link
Collaborator

fruffy commented Mar 14, 2025

@vbnogueira Now we should we able to run this with the test framework you have added to p4tc, right?

@vbnogueira
Copy link
Contributor Author

@vbnogueira Now we should we able to run this with the test framework you have added to p4tc, right?

Sorry for the late reply
Yes, we should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy Awaiting requested review from fruffy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
p4tc Topics related to the P4-TC back end. On PRs, also triggers p4tc CI tests to run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbnogueira @fruffy