fix warnings from -Wswitch-enum #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-warnings
branch
from
d9e05e8 to
f54f2cf
Compare
ChrisDodd
force-pushed
the
cdodd-warnings
branch
2 times, most recently
from
d5206da to
e6a9727
Compare
vlstill
reviewed
Mar 10, 2025
| @@ -135,7 +135,10 @@ class JSONGenerator { | |||
| break; | |||
| case OBJ_END: | |||
| break; | |||
| default: | |||
There was a problem hiding this comment.
I wonder, should the default: still exist in case new enum value is added or somehow we get value which is not one of the enumerated once?
There was a problem hiding this comment.
Well, adding a new switch value will trigger the -Wswitch-case warning again, regardless of whether default is present or not. Since getting a value that is not a valid tag value (from memory corruption or uninitialized data) would only be possible with undefined behavior, it is not clear what adding default would actually gain.
vlstill
approved these changes
Mar 10, 2025
ChrisDodd
force-pushed
the
cdodd-warnings
branch
from
e6a9727 to
04698c7
Compare
fruffy
added
the
core
ChrisDodd
force-pushed
the
cdodd-warnings
branch
from
04698c7 to
f6b1795
Compare
Signed-off-by: Chris Dodd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.