Fix/prevent absolute imports #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some IDEs (such as VS Code) are aware of the `baseUrl' property, and will auto-complete imports using the base URL as a prefix in the import, instead of a relative URL. This creates problems for consumers of the library, as the path is no longer relative to the top level project base (I think). Even if this is untrue, it's best to stick with a single, consistent approach. As an example, see a20ad80 which had to correct one such problem. See also #974
|
The Windows build failure is unrelated, it seems the recent "fix" for that did not stick 🤔 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change detects any use of absolute paths such as
dsl/message, resulting in a compilation failure.VS Code (and hopefully other IDEs) will not auto-suggest/import these paths, and provide helpful hints such as the following if they are used:
See also #974