Implement remote and default config loading #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the go-githubapp/appconfig package to support remote configuration references and organization-level defaults. To make this simpler to implement, there are two changes to existing behavior: 1. If any config is invalid, Bulldozer stops processing the PR and logs a warning. Previously, it would fall back to global config (if set) in this case. 2. All defined config paths may contain either v1 or v0 configuration. Previously, some paths could only contain one version or the other. Since v0 config is undocumented and has been deprecated for a long-time, I don't expect this to impact anything. I also did some refactoring, moving the fetching logic to the handler package while leaving the parsing logic in the bulldozer package. This mirrors the layout in policy-bot.
asvoboda
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the go-githubapp/appconfig package to support remote configuration
references and organization-level defaults. To make this simpler to
implement, there are two changes to existing behavior:
If any config is invalid, Bulldozer stops processing the PR and logs
a warning. Previously, it would fall back to global config (if set)
in this case.
All defined config paths may contain either v1 or v0 configuration.
Previously, some paths could only contain one version or the other.
Since v0 config is undocumented and has been deprecated for a
long time, I don't expect this to impact anything.
I also did some refactoring, moving the fetching logic to the handler
package while leaving the parsing logic in the bulldozer package. This
mirrors the layout in policy-bot.