Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 compatibility #20

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Rails 6 compatibility #20

merged 2 commits into from
Apr 11, 2019

Conversation

palkan
Copy link
Owner

@palkan palkan commented Mar 1, 2019

No code changes required.

Tests have been updated to reflect the lazy transactions feature.

@palkan palkan changed the title Fix Rails 6 compatibility Rails 6 compatibility Apr 11, 2019
palkan added 2 commits April 11, 2019 17:24
Rails 6 introduces lazy transactions, so we need to perform a query first
@palkan palkan marked this pull request as ready for review April 11, 2019 21:25
@palkan palkan merged commit 82482b5 into master Apr 11, 2019
@palkan palkan deleted the fix/rails6 branch April 11, 2019 21:42
Envek added a commit to Envek/after_commit_everywhere that referenced this pull request Sep 10, 2019
It broke due new to [Lazy transactions](rails/rails#32647) feature.

Workaround is taken from the Isolator gem: palkan/isolator#20
andrebarretofv added a commit to andrebarretofv/after_commit_everywhere that referenced this pull request Jul 10, 2024
It broke due new to [Lazy transactions](rails/rails#32647) feature.

Workaround is taken from the Isolator gem: palkan/isolator#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant