Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows #45364

Merged
merged 5 commits into from
Jan 18, 2022

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jan 14, 2022

Closes #45344

@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Jan 14, 2022
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Jan 14, 2022

So updating pyarrow from 1.0 to 2.0 seems to highlight some other bugs ..

(edit: the xfails for this have been updated in #45257 in the meantime)

@jbrockmendel
Copy link
Member

So updating pyarrow from 1.0 to 2.0 seems to highlight some other bugs ..

Something like this seems to happen frequently. I've got an under-utilized ubuntu machine that i could set up with 'tox' to run the tests daily(ish) with a thorough(ish) matrix of pyarrow versions. Would that be useful? If this is windows-specific then never mind.

@jreback jreback added this to the 1.4 milestone Jan 16, 2022
@jreback
Copy link
Contributor

jreback commented Jan 16, 2022

closing in favor of #45354 which is already merged & backported

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Jan 18, 2022

closing in favor of #45354 which is already merged & backported

#45354 is only xfailing the test, while this PR is an initial attempt to actually fix #45344 (which is still open)

Something like this seems to happen frequently. I've got an under-utilized ubuntu machine that i could set up with 'tox' to run the tests daily(ish) with a thorough(ish) matrix of pyarrow versions. Would that be useful? If this is windows-specific then never mind.

I don't think it is windows-specific (it's a fsspec / pyarrow incompatible version combination). But I also don't think it's necessarily needed for you to set up separate testing against more versions of pyarrow (or at least it should not be needed, we should "simply" do this better on our CI). I would first try to diversify the version in our own CI matrix (eg we can already reduce the number of builds that pins against pyarrow=1.0.1).

@jreback
Copy link
Contributor

jreback commented Jan 18, 2022

this looks good thanks @jorisvandenbossche

@jreback jreback merged commit 91f12c4 into pandas-dev:main Jan 18, 2022
@jreback
Copy link
Contributor

jreback commented Jan 18, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 18, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 91f12c44d94b4d399e3f2321edb7c35c91998242
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #45364: CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows'
  1. Push to a named branch:
git push YOURFORK 1.4.x:auto-backport-of-pr-45364-on-1.4.x
  1. Create a PR against branch 1.4.x, I would have named this PR:

"Backport PR #45364 on branch 1.4.x (CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 18, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 91f12c44d94b4d399e3f2321edb7c35c91998242
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #45364: CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows'
  1. Push to a named branch:
git push YOURFORK 1.4.x:auto-backport-of-pr-45364-on-1.4.x
  1. Create a PR against branch 1.4.x, I would have named this PR:

"Backport PR #45364 on branch 1.4.x (CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Jan 18, 2022

@jorisvandenbossche if you wouldn't mind pushing the manual backport here

@jorisvandenbossche
Copy link
Member Author

-> #45450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: error in parquet tests on windows with new pyarrow exception
3 participants