-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows #45364
CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows #45364
Conversation
So updating pyarrow from 1.0 to 2.0 seems to highlight some other bugs .. (edit: the xfails for this have been updated in #45257 in the meantime) |
Something like this seems to happen frequently. I've got an under-utilized ubuntu machine that i could set up with 'tox' to run the tests daily(ish) with a thorough(ish) matrix of pyarrow versions. Would that be useful? If this is windows-specific then never mind. |
closing in favor of #45354 which is already merged & backported |
#45354 is only xfailing the test, while this PR is an initial attempt to actually fix #45344 (which is still open)
I don't think it is windows-specific (it's a fsspec / pyarrow incompatible version combination). But I also don't think it's necessarily needed for you to set up separate testing against more versions of pyarrow (or at least it should not be needed, we should "simply" do this better on our CI). I would first try to diversify the version in our own CI matrix (eg we can already reduce the number of builds that pins against pyarrow=1.0.1). |
this looks good thanks @jorisvandenbossche |
@meeseeksdev backport 1.4.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@jorisvandenbossche if you wouldn't mind pushing the manual backport here |
-> #45450 |
Closes #45344