Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: consistency of input args for boundaries - Interval #46522

Merged
merged 89 commits into from
May 30, 2022
Merged

ENH: consistency of input args for boundaries - Interval #46522

merged 89 commits into from
May 30, 2022
+1,046 −681

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Mar 26, 2022 •
edited by jreback
Loading

Sorry, something went wrong.

Update interval.pyi

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
538ba43
@weikhor weikhor closed this Mar 26, 2022
@weikhor weikhor deleted the enh-consistency-interval-index branch March 26, 2022 15:56
@weikhor weikhor restored the enh-consistency-interval-index branch March 26, 2022 15:57
@weikhor weikhor reopened this Mar 26, 2022
Khor Chean Wei added 6 commits March 27, 2022 00:01
Update interval.pyx

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a9da7bd
Update intervaltree.pxi.in

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b222280
Update lib.pyx

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
466f35a
Update asserters.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
323f0d8
Update _arrow_utils.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c4931c9
Update interval.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
40bfa76
@pep8speaks
Copy link

pep8speaks commented Mar 26, 2022 •
edited
Loading

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-30 12:21:22 UTC

Khor Chean Wei added 13 commits March 27, 2022 00:07
Update cast.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
23ad9c8
Update dtypes.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f700477
Update interval.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3835d29
Update blocks.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6ac2f6a
Update tile.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e53605d
first
8a8f38c
add
97f7b9e
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d20b1be
pre commit
a8a3266
pre commit
a4d58dc
pre commit
edf53b7
pre commit
d0f17c0
pre commit
b00a947
@weikhor weikhor closed this Mar 27, 2022
@weikhor weikhor reopened this Mar 27, 2022
@weikhor weikhor closed this Mar 27, 2022
@weikhor weikhor reopened this Mar 27, 2022
@weikhor
Copy link
Contributor Author

weikhor commented Mar 27, 2022

Hi There is still issues inside code PR submit. Will tag reviewers once I finish. Thank

weikhor added 8 commits May 19, 2022 01:40
update warning_interval
eab8b58
resolve conflict
f234f07
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ff53d3f
pickle
fe62e50
Update dtypes.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a73ec91
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
12c7806
pickle
757cabf
pickle
82d58b0
@jreback
Copy link
Contributor

jreback commented May 25, 2022

can you rebase this (as the pickle fix was merged)

@jreback
Copy link
Contributor

jreback commented May 27, 2022

can you rebase once more

Khor Chean Wei added 5 commits May 28, 2022 00:26
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c8c6193
mypy
41f59fb
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
17b54ad
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b73f4ba
Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8cbeca0
@jreback
Copy link
Contributor

jreback commented May 29, 2022

the doc build is failing, which is working on master; its possible its superfluous, so if it builds locally can you rebase again.

Merge branch 'main' into enh-consistency-interval-index

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
35b18ea
@weikhor
Copy link
Contributor Author

weikhor commented May 30, 2022

@jreback The pipeline in greeen

jreback
jreback approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @weikhor this is great!

@jreback jreback merged commit 7e23a37 into pandas-dev:main May 30, 2022
@jreback jreback mentioned this pull request May 30, 2022
Closed
@weikhor weikhor deleted the enh-consistency-interval-index branch May 31, 2022 16:12
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 15, 2022
Closed
3 tasks
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@yehoshuadimarsky
ENH: consistency of input args for boundaries - Interval (pandas-dev#…
27ec3e4 
…46522)
mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 17, 2022
@mroeschke
Revert "ENH: consistency of input args for boundaries - Interval (pan…
36a3d8e 
…das-dev#46522)"

This reverts commit 7e23a37.
@mroeschke mroeschke mentioned this pull request Aug 17, 2022
Merged
mroeschke added a commit that referenced this pull request Aug 18, 2022
@mroeschke @phofl
Revert Interval/IntervalIndex/interval_range.inclusive deprecation (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
252ae05 
…48116)

* Revert "Cln tests interval wrt inclusive (#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <[email protected]>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @phofl @noatamir
Revert Interval/IntervalIndex/interval_range.inclusive deprecation (p…
602ac75 
…andas-dev#48116)

* Revert "Cln tests interval wrt inclusive (pandas-dev#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (pandas-dev#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (pandas-dev#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel

@jreback jreback

Assignees
No one assigned
Labels
Interval Interval data type
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weikhor @pep8speaks @jreback @jbrockmendel