CI: start testing Python 3.11 #47442

fangchenli · 2022-06-21T05:57:11Z

xref ENH: Support Python 3.11 #46680 (Replace xxxx with the Github issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke · 2022-06-21T23:58:20Z

Is this going to supersede #47032?

fangchenli · 2022-06-22T17:37:35Z

Didn't realize there is an existing PR...

lithomas1 · 2022-06-22T17:47:12Z

You can just push to my PR directly if you want, or pull the changes here. It's a little farther down the pipeline, but I will not have time to work on it in the near future.

fangchenli · 2022-06-22T20:15:13Z

FAILED pandas/tests/arrays/categorical/test_api.py::TestCategoricalAPI::test_set_ordered
FAILED pandas/tests/arrays/categorical/test_api.py::TestPrivateCategoricalAPI::test_codes_immutable
FAILED pandas/tests/indexes/multi/test_get_set.py::test_set_levels_codes_directly
FAILED pandas/tests/indexes/period/test_freq_attr.py::TestFreq::test_freq_setter_deprecated
FAILED pandas/tests/io/parser/test_quoting.py::test_null_quote_char[python--0]
FAILED pandas/tests/io/parser/test_quoting.py::test_null_quote_char[python--3]
FAILED pandas/tests/io/parser/common/test_read_errors.py::test_null_byte_char[python]
ERROR pandas/tests/scalar/test_nat.py - TypeError: '<' not supported between ...
ERROR pandas/tests/scalar/test_nat.py - TypeError: '<' not supported between ...

lithomas1 · 2022-06-23T13:50:22Z

FYI Windows will also fail until #47467 is merged in.

pep8speaks · 2022-06-24T22:35:15Z

Hello @fangchenli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-17 19:19:05 UTC

lithomas1 · 2022-08-02T20:17:49Z

@fangchenli
Thanks for picking this up. There haven't been commits on this PR in a while, so I was wondering whether you had the time to finish this PR up.

I've merged main into this PR for you just to see where we're at with the failures.

I'm pretty close to finishing off #47467, and am going to try to get it merged this week. I think I have enough time where I'll be able to finish it up, hopefully before 3.11rc1.

lithomas1 · 2022-08-11T17:07:52Z

I accidentally pushed some commits here(I misconfigured github cli-meant to push to my own branch and pull request to this one), so I decided to go all the way to getting CI green. Sorry about the noise.

At any rate, this is ready now pending #47467 merge.

lithomas1 · 2022-08-11T17:09:12Z

.github/workflows/python-dev.yml

@@ -1,11 +1,3 @@
-# This file is purposely frozen(does not run). DO NOT DELETE IT


I think it would be better to leave the comment in, and just comment out the if: false below.

Agreed. Even better to clarify

"Freeze" if our dependencies don't support the latest python dev version

"Unfreeze" if our dependencies support it, but the python dev version hasn't been officially released

@fangchenli Do you have any objections here?

@fangchenli Do you have any objections here?

No, I agree with you and @mroeschke

pandas/tests/io/parser/common/test_read_errors.py

mroeschke

Looks good. Just need to address #47442 (comment)

mroeschke

LGTM pending green

fangchenli · 2022-08-17T18:49:44Z

@lithomas1 Thank you very much for finishing this up.

lithomas1 · 2022-08-17T23:01:35Z

@lithomas1 Thank you very much for finishing this up.

Thanks for picking this up again.

* CI: start testing Python 3.11 * fix * fix * fix macos * add error msg compat * fix error msg in test * xfail and skip tests * fix error * roll back * revert * maybe fix errors * update * try something * pin hypothesis * Don't check parentheses equality * typo * pin cython * correctly pin hypothesis * adjust test * remove compiler flag * typo'ed * fix tests * linter * clarify freeze/unfreeze instructions * whitespace * one more Co-authored-by: Thomas Li <[email protected]>

fangchenli added 3 commits June 20, 2022 22:55

CI: start testing Python 3.11

5fbeaeb

fix

4805a6b

fix

9f038f3

Merge remote-tracking branch 'upstream/main' into test-py311

532ce7d

fangchenli added the Python 3.11 label Jun 22, 2022

fix macos

2b45e32

add error msg compat

bfbd17b

fangchenli added 4 commits June 23, 2022 10:08

fix error msg in test

bac8cbd

Merge remote-tracking branch 'upstream/main' into test-py311

f9bd7de

Merge remote-tracking branch 'upstream/main' into test-py311

df998dc

xfail and skip tests

572acef

fangchenli added 3 commits June 24, 2022 18:12

fix error

c5f2fe3

roll back

69ea5ed

Merge remote-tracking branch 'upstream/main' into test-py311

a244f85

lithomas1 mentioned this pull request Jun 29, 2022

DEPS/TST: tzdata is optional, not required #47467

Merged

5 tasks

fangchenli added 5 commits June 29, 2022 20:38

Merge remote-tracking branch 'upstream/main' into test-py311

981c5a9

Merge remote-tracking branch 'upstream/main' into test-py311

110459a

revert

267c9f2

Merge remote-tracking branch 'upstream/main' into test-py311

b6e0e22

Merge remote-tracking branch 'upstream/main' into test-py311

6979eb1

lithomas1 mentioned this pull request Jul 30, 2022

CI: Start Testing on Python 3.11 #47032

Closed

4 tasks

Merge branch 'main' into test-py311

097e98b

lithomas1 mentioned this pull request Aug 2, 2022

TST: Allow “no setter” messages from Python 3.11 #47929

Closed

5 tasks

lithomas1 added 8 commits August 7, 2022 08:36

try something

ad5eef1

pin hypothesis

71ab88d

Don't check parentheses equality

aca30a0

typo

11c9269

pin cython

5cfb071

correctly pin hypothesis

668c53e

adjust test

827a648

remove compiler flag

5fb3daa

typo'ed

b1a58fe

lithomas1 reviewed Aug 11, 2022

View reviewed changes

lithomas1 marked this pull request as ready for review August 12, 2022 00:45

lithomas1 added this to the 1.5 milestone Aug 12, 2022

mroeschke reviewed Aug 12, 2022

View reviewed changes

pandas/tests/io/parser/common/test_read_errors.py Show resolved Hide resolved

lithomas1 added 5 commits August 11, 2022 19:16

Merge branch 'main' into test-py311

c68f7e0

Merge branch 'main' into test-py311

fd17b61

fix tests

354b12c

linter

54023de

Merge branch 'main' into test-py311

78a4a46

mroeschke reviewed Aug 17, 2022

View reviewed changes

lithomas1 added 2 commits August 17, 2022 11:05

clarify freeze/unfreeze instructions

9adcc80

Merge branch 'main' into test-py311

1ac995e

mroeschke approved these changes Aug 17, 2022

View reviewed changes

whitespace

ce6a0a4

one more

0b32782

lithomas1 merged commit b3f8ab4 into pandas-dev:main Aug 17, 2022

fangchenli deleted the test-py311 branch August 17, 2022 22:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: start testing Python 3.11 #47442

CI: start testing Python 3.11 #47442

fangchenli commented Jun 21, 2022 •

edited by lithomas1

Loading

mroeschke commented Jun 21, 2022

fangchenli commented Jun 22, 2022

lithomas1 commented Jun 22, 2022

fangchenli commented Jun 22, 2022

lithomas1 commented Jun 23, 2022

pep8speaks commented Jun 24, 2022 •

edited

Loading

lithomas1 commented Aug 2, 2022

lithomas1 commented Aug 11, 2022 •

edited

Loading

lithomas1 Aug 11, 2022

mroeschke Aug 12, 2022 •

edited

Loading

lithomas1 Aug 16, 2022

fangchenli Aug 17, 2022

mroeschke left a comment

mroeschke left a comment

fangchenli commented Aug 17, 2022

lithomas1 commented Aug 17, 2022

		@@ -1,11 +1,3 @@
		# This file is purposely frozen(does not run). DO NOT DELETE IT

CI: start testing Python 3.11 #47442

CI: start testing Python 3.11 #47442

Conversation

fangchenli commented Jun 21, 2022 • edited by lithomas1 Loading

mroeschke commented Jun 21, 2022

fangchenli commented Jun 22, 2022

lithomas1 commented Jun 22, 2022

fangchenli commented Jun 22, 2022

lithomas1 commented Jun 23, 2022

pep8speaks commented Jun 24, 2022 • edited Loading

Comment last updated at 2022-08-17 19:19:05 UTC

lithomas1 commented Aug 2, 2022

lithomas1 commented Aug 11, 2022 • edited Loading

lithomas1 Aug 11, 2022

Choose a reason for hiding this comment

mroeschke Aug 12, 2022 • edited Loading

Choose a reason for hiding this comment

lithomas1 Aug 16, 2022

Choose a reason for hiding this comment

fangchenli Aug 17, 2022

Choose a reason for hiding this comment

mroeschke left a comment

Choose a reason for hiding this comment

mroeschke left a comment

Choose a reason for hiding this comment

fangchenli commented Aug 17, 2022

lithomas1 commented Aug 17, 2022

fangchenli commented Jun 21, 2022 •

edited by lithomas1

Loading

pep8speaks commented Jun 24, 2022 •

edited

Loading

lithomas1 commented Aug 11, 2022 •

edited

Loading

mroeschke Aug 12, 2022 •

edited

Loading