BUG: infer-objects raising for bytes Series #50067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Dtype Conversions
jbrockmendel
reviewed
Dec 5, 2022
| @@ -1969,6 +1969,9 @@ def convert( | |||
| attempt to cast any object types to better types return a copy of | |||
| the block (if copy = True) by definition we ARE an ObjectBlock!!!!! | |||
| """ | |||
| if self.dtype != object: | |||
| return [self] | |||
There was a problem hiding this comment.
i think this may need to make a copy in some cases?
There was a problem hiding this comment.
Are you sure?
ser = Series(["a"], dtype="object")
result = ser.infer_objects()
result.iloc[0] = "c"
print(ser)
this updates ser as well, same as the bytes version. If we add a copy, the bytes version would not update anymore
There was a problem hiding this comment.
- infer_objects in principle makes a copy in cases where it doesn't do inference. 2) I don't think that's what most users (or our internal usages) actually want. 3) ATM the ObjectBlock case that doesn't do inference doesn't make a copy, which is inconsistent with other dtypes. 4) i think adding a copy keyword makes sense xref ENH/PERF: copy=True keyword in methods where copy=False can improve perf #48141, but adding copy keywords in general got pushback recently
There was a problem hiding this comment.
I guess we can ignore this since were not consistent about it anyway
|
Needs rebase |
# Conflicts: # pandas/tests/series/methods/test_infer_objects.py
# Conflicts: # pandas/tests/series/methods/test_infer_objects.py
|
rebased |
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe_convert_objectsfails for byte series #49650 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel