-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: NumPy func warning when dropping nuisance in agg, apply, transform #50627
Conversation
@jorisvandenbossche @jbrockmendel @mroeschke for any thoughts/feedback |
In case we keep the current behaviour (no special handling of |
@jorisvandenbossche - I think trying to change the pass through behavior is too tricky for a patch (this is targeted to go straight into 1.5.3). I do plan to work on it for future versions (e.g. #50624). If you want this to not close #50538, I can remove it from the OP here, but I do think this is the safest route for 1.5.3. |
@mroeschke - friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agreed that improving the exception message here is more reasonable than try to shim numeric_only
support of any kind
Thanks @rhshadrach |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.