BUG/CoW: Series.rename not making a lazy copy when passed a scalar #53189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
May 13, 2023
pandas/core/series.py
Outdated
| @@ -4667,7 +4671,9 @@ def rename( | |||
| errors=errors, | |||
| ) | |||
| else: | |||
| return self._set_name(index, inplace=inplace) | |||
| return self._set_name( | |||
| index, inplace=inplace, deep=copy and not using_copy_on_write() | |||
There was a problem hiding this comment.
Any reason we are doing this here and not in _set_name?
There was a problem hiding this comment.
Simply passing copy through should be sufficient though
There was a problem hiding this comment.
It's to ignore copy=True, when Copy on Write is activated. I just copy pasted from your code in #51464
There was a problem hiding this comment.
Nothing else calls _set_name other than rename, so I just left the Copy on Write logic in rename itself. I can move it if you want me to.
There was a problem hiding this comment.
Probably more consistent to push it down, but not a really strong opinion
phofl
approved these changes
May 14, 2023
|
thx @lithomas1 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
May 14, 2023
…y copy when passed a scalar
lithomas1
added a commit
that referenced
this pull request
May 14, 2023
… a lazy copy when passed a scalar) (#53221) * Backport PR #53189: BUG/CoW: Series.rename not making a lazy copy when passed a scalar * Update test_setitem.py --------- Co-authored-by: Thomas Li <[email protected]>
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I put this in for 2.0.2 since we claim that the lazy-copy was implemented for
renamein 2.0