-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken 0.9.3 release by delaying kerchunk.netCDF3
import
#466
Conversation
I can unblock Pangeo Forge Cloud by using this branch for the moment. @rabernat how would you like to handle this from a release standpoint? Should we yank |
Can we make this a runtime optional dependency rather than a required dependency? Scipy is huge. Can't we just pip install it directly in the cloud environment? Making something a required dependency of pangeo forge recipes should not be the only way to get a package into our environment. |
Yes, I see your point about scipy's size. I guess this will require ImportError exception handling along the lines of: https://github.com/fsspec/kerchunk/search?q=ImportError because currently in |
Ok, now I understand that pangeo forge recipes is not even importable without scipy. That's bad. Unfortunately we do need a new release. Let's put the optional import here. pangeo-forge-recipes/pangeo_forge_recipes/reference.py Lines 18 to 19 in 6b29c8a
|
Decided not to handle the error because kerchunk will give us a descriptive message if scipy is missing: |
kerchunk[netcdf3]
kerchunk.netCDF3
import
kerchunk.netCDF3
importkerchunk.netCDF3
import
I'll merge, pull |
This recipe test attempted in pangeo-forge/C-iTRACE-feedstock#5 (comment) failed, and server logs reveal that this issue is that
pangeo-forge-recipes/pangeo_forge_recipes/reference.py
Line 8 in 6b29c8a
requires scipy, which we do not require on install. The
kerchunk[netcdf3]
option added in this PR will bring this in via kerchunk. The issue can be reproduced by pip-installingpangeo-forge-recipes==0.9.3
in a blank conda environment, and then:Our CI testing let this through, because scipy is brought into the dev environment those tests run in.