Parquet storage option for reference recipe #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisaacstern
reviewed
Sep 19, 2023
cisaacstern
reviewed
Sep 19, 2023
cisaacstern
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Almost there, @norlandrhagen! Thanks so much for your work on this.
Just two suggestions below to generalize storage definitions for non-local storage. As we discussed in person last week, I think minio testing would help us catch these points in testing, and I've opened #623 to track that, but we don't need to let minio testing become a blocker to this work, just something to keep in mind for the future.
Co-authored-by: Charles Stern <[email protected]>
Co-authored-by: Charles Stern <[email protected]>
for more information, see https://pre-commit.ci
cisaacstern
reviewed
Sep 19, 2023
cisaacstern
added
the
test-integration
|
Awesome, thanks for the persistence on this one, @norlandrhagen! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened PR that implements #594.