Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow injectable attrs in StoreToZarr #622

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Allow injectable attrs in StoreToZarr #622

merged 7 commits into from
Sep 19, 2023

Conversation

norlandrhagen
Copy link
Contributor

PR to implement the ability to inject attrs into the StoreToZarr transformation.

  • Should preserve existing attrs
  • Tags injected attrs with pangeo-forge: prefix.
| StoreToZarr(..., add_attrs={'some_name', 'some_value'})
image

#559

@norlandrhagen norlandrhagen marked this pull request as ready for review September 18, 2023 18:28
@cisaacstern cisaacstern added the test-integration Apply this label to run integration tests on a PR. label Sep 19, 2023
cisaacstern
cisaacstern approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norlandrhagen, LGTM!

@cisaacstern cisaacstern merged commit 1180744 into pangeo-forge:main Sep 19, 2023
@norlandrhagen norlandrhagen mentioned this pull request Sep 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 left review comments

@cisaacstern cisaacstern cisaacstern approved these changes

Assignees
No one assigned
Labels
test-integration Apply this label to run integration tests on a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norlandrhagen @andersy005 @cisaacstern