-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minio
to Integration Tests
#638
Conversation
|
The minio integration tests are failing locally for the pytest tests/test_integration.py -k 'test_integration[minio_confpath-noaa-oisst]' --run-integration Traceback:
|
using docker-py b/c it seems more stable and we don't have to guess about local IP
for more information, see https://pre-commit.ci
… + updated ci/integration
…get loaded in non-integration tests
minio
to Integration Tests minio
to Integration Tests
Note: The inconsistent minio failures were remedied with a fix from @ranchodeluxe! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just some small golfing comments
Thanks for the review @ranchodeluxe! |
Co-authored-by: Charles Stern <[email protected]>
@norlandrhagen sorry I was just going to say, I think we need a follow-on to this that restores the assert proc.returncode == 0 because it looks like at least one of the integration tests was failing silently here: |
Actually both of the minio test cases are failing, here's the other one: but without that assert they are registering to pytest as passes. |
Adds
minio
to integration tests to allow the integration tests to be ran against ans3
bucket.