Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout tags for local install #650

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Checkout tags for local install #650

merged 4 commits into from
Nov 19, 2023

Conversation

jbusecke
Copy link
Contributor

Following @keewis suggestion in #595 (comment) adding this to checkout tags

@jbusecke
Copy link
Contributor Author

Ah thanks for catching this @keewis (sorry I should have double checked this myself, but am currently happily hacking away on other things). Also good to know you have Pangeo-Forge on your radar in general!

@keewis
Copy link
Contributor

keewis commented Nov 16, 2023

looks like CI didn't run for some reason?

@jbusecke
Copy link
Contributor Author

Weird...Is this the correct run? Let me try to rerun this.

@jbusecke
Copy link
Contributor Author

Seems like this is some gh issue. If you click on the small status symbol next to the commits they are displayed...
image

@keewis
Copy link
Contributor

keewis commented Nov 18, 2023

In any case, looks like the installed version is correct now.

@jbusecke
Copy link
Contributor Author

Yep and the tests seem to show up again (at least on mobile). I think this is ready to merge.

@jbusecke jbusecke merged commit 32d3864 into main Nov 19, 2023
@jbusecke jbusecke deleted the checkout-tags-in-ci branch November 19, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants