remove explicit uses of lazy_static #22015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolsson
added
the
release-notes:not-required
tgolsson
force-pushed
the
ts/remove-lazy-static
branch
from
5044dd5 to
8063bbf
Compare
tdyas
approved these changes
Feb 26, 2025
|
Good timing :) I flagged lazy_static (due to the same Dependabot) in #22012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw #22011, but I figured we might as well remove the dependency from our code since it's equivalent to LazyLock now.
There's two minor "extra" changes: char hashsets with a handful of entries, and an actual constant. Both are just simplification and it should have no effect on performance.