chore(deps): 2024 edition syntax fixes #14731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
the
A-dependencies
mattsse
reviewed
Feb 26, 2025
would still include the syntax fixes in this pr, last edition let them pass through, i.e. last edition can also compile this syntax, rules just got stricter in 2024 |
emhane
changed the title
mattsse
added
the
S-blocked
|
these syntax fixes are unavoidable @mattsse , how come this is blocked? |
There was a problem hiding this comment.
Copilot reviewed 118 out of 118 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
crates/e2e-test-utils/src/wallet.rs:35
- Renaming the function to 'wallet_gen' improves clarity over the previous generic name 'gen'. Ensure that all callers and documentation references have been updated accordingly.
pub fn wallet_gen(&self) -> Vec<PrivateKeySigner> {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes syntax wrt edition 2024