Skip to content

chore(rpc): Remove redundancy in eth API trait bounds #15508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

emhane
Copy link
Member

@emhane emhane commented Apr 3, 2025

Towards #14863

Removes redundancy in eth API trait bounds

summary of changes tbc

@emhane emhane added C-debt A clean up/refactor of existing code A-sdk Related to reth's use as a library labels Apr 3, 2025
@emhane emhane marked this pull request as draft April 3, 2025 15:26
@emhane emhane requested a review from Copilot April 4, 2025 10:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

@emhane
Copy link
Member Author

emhane commented Apr 4, 2025

this triggers some compiler bug when compiling docs, perhaps you can have a look at it @DaniPopes ?

@emhane emhane marked this pull request as ready for review April 4, 2025 16:49
@DaniPopes
Copy link
Member

DaniPopes commented Apr 4, 2025

🤷 rustdoc bug, report it

@emhane
Copy link
Member Author

emhane commented Apr 4, 2025

🤷 rustdoc bug, report it

not sure I know how to make the minimal repro, if you want to, pls go ahead. otherwise will look into it on Monday. thanks!

@emhane emhane requested a review from rkrasiuk as a code owner April 8, 2025 10:01
@emhane emhane force-pushed the emhane/simplify-linkage-eth-api-tys branch from 83fb142 to 0c40b4f Compare April 8, 2025 10:10
@emhane
Copy link
Member Author

emhane commented Apr 9, 2025

🤷 rustdoc bug, report it

bug has already been reported rust-lang/rust#91380, commented on the issue

@emhane emhane enabled auto-merge April 14, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants