feat: add support for Eth69 receipts representation #15619
Conversation
stevencartavia
requested review from
mattsse,
Rjected and
fgimenez
as code owners
There was a problem hiding this comment.
great start, but we now must also duplicate the _inner functions without the bloom
see:
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7642.md#specification
| } | ||
|
|
||
| fn encode_2718(&self, out: &mut dyn BufMut) { | ||
| self.rlp_encode_with_bloom(&self.bloom(), out); |
There was a problem hiding this comment.
this impl should use the bloom, instead we need to encode all of the fields without the bloom
basically just this without the bloom:
reth/crates/ethereum/primitives/src/receipt.rs
Lines 44 to 50 in 460f840
mattsse
added
C-enhancement
|
|
||
| impl Encodable2718 for Receipt { | ||
| fn encode_2718_len(&self) -> usize { | ||
| !self.tx_type.is_legacy() as usize + self.rlp_encoded_fields_length_without_bloom() |
There was a problem hiding this comment.
not sure this is correct because this doesn't include the rlp header
There was a problem hiding this comment.
yeah this should be smth like
| !self.tx_type.is_legacy() as usize + self.rlp_encoded_fields_length_without_bloom() | |
| !self.tx_type.is_legacy() as usize + self.rlp_header_inner_without_bloom().length_with_payload() |
| Self::Deposit(receipt) => { | ||
| receipt.inner.status.length() + | ||
| receipt.inner.cumulative_gas_used.length() + | ||
| receipt.inner.logs.length() | ||
| } |
There was a problem hiding this comment.
this should encode deposit nonce and version, if those are present
| receipt.inner.status.encode(out); | ||
| receipt.inner.cumulative_gas_used.encode(out); | ||
| receipt.inner.logs.encode(out); |
| deposit_nonce: None, | ||
| deposit_receipt_version: None, |
There was a problem hiding this comment.
thiose should be decoded and not always set to None
|
@klkvr updated :) |
|
|
||
| impl Encodable2718 for Receipt { | ||
| fn encode_2718_len(&self) -> usize { | ||
| self.rlp_header_inner_without_bloom().length_with_payload() |
There was a problem hiding this comment.
this should still account for the type byte (!self.tx_type.is_legacy())
| if let Some(nonce) = receipt.deposit_nonce { nonce.length() } else { 0 } + | ||
| if let Some(version) = receipt.deposit_receipt_version { | ||
| version.length() | ||
| } else { | ||
| 0 | ||
| } |
| let mut deposit_receipt_version = None; | ||
|
|
||
| // For deposit receipts, try to decode nonce and version if they exist | ||
| if tx_type == OpTxType::Deposit && buf.len() + header.payload_length < remaining { |
There was a problem hiding this comment.
I think this should be buf.len() + header.payload_length > remaining?
There was a problem hiding this comment.
I'd prefer us to have some roundtrips here to catch such stuff
closes #15509