feat: add no-local-exemptions settings to MaintainPoolConfig #15651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Apr 10, 2025
There was a problem hiding this comment.
nits, we also need to configure this when we create it
reth/crates/ethereum/node/src/node.rs
Line 411 in d68dd40
| /// This includes: | ||
| /// - no price exemptions | ||
| /// - no eviction exemptions | ||
| pub no_exemptions: bool, |
There was a problem hiding this comment.
Suggested change
| pub no_exemptions: bool, | |
| pub no_local_exemptions: bool, |
Comment on lines
268
to
275
| // filter stale transactions based on config | ||
| if config.no_exemptions { | ||
| // if no exemptions, treat all transactions the same | ||
| tx.timestamp.elapsed() > config.max_tx_lifetime | ||
| } else { | ||
| // only evict external transactions | ||
| tx.origin.is_external() && tx.timestamp.elapsed() > config.max_tx_lifetime | ||
| } |
There was a problem hiding this comment.
we can simplify this a bit by combining the first tx.origin.is_external() with config.no_exemptions
(config.no_exemptions || tx.origin.is_external())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15638