Skip to content

fix(era1): use framed snap encoding/decoding instead of raw one #15652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix(era1): use framed snap encoding/decoding instead of raw one #15652

merged 1 commit into from
Apr 10, 2025

Conversation

lean-apple
Copy link
Contributor

@lean-apple lean-apple commented Apr 9, 2025 •
edited
Loading

When testing reading and decoding of .era1 files, like in this PR, I encountered issues decoding the header with the raw snappy decoder.

Switching to the framed Snappy encoding/decoding , with FrameDecoder and FrameEncoder solved these issues.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Apr 9, 2025
@lean-apple lean-apple changed the title fix(era1): use frame snap rlp encoding/decoding fix(era1): use framed snap encoding/decoding instead of raw one Apr 9, 2025
@lean-apple lean-apple marked this pull request as ready for review April 9, 2025 19:12
@lean-apple lean-apple requested a review from mattsse as a code owner April 9, 2025 19:12
mattsse
mattsse approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see
nice

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Apr 10, 2025
@mattsse mattsse added this pull request to the merge queue Apr 10, 2025
@mattsse mattsse added the C-enhancement New feature or request label Apr 10, 2025
Merged via the queue into paradigmxyz:main with commit f217ec5 Apr 10, 2025
46 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 10, 2025
@lean-apple lean-apple deleted the fix-snap-decoder branch April 11, 2025 03:50
@lean-apple lean-apple mentioned this pull request Apr 15, 2025
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lean-apple @mattsse