Skip to content

feat: adding cli --rpc.txfeecap flag #15654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 15, 2025

Conversation

rrrengineer
Copy link
Contributor

Working on #15618

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, great start, some suggestions

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Apr 10, 2025
@mattsse mattsse added A-tx-pool Related to the transaction mempool A-cli Related to the reth CLI labels Apr 10, 2025
@rrrengineer rrrengineer marked this pull request as ready for review April 11, 2025 04:55
@rrrengineer
Copy link
Contributor Author

rrrengineer commented Apr 11, 2025

Implementation tested with op-reth full node

  • no flag, default value 1 ETH
  • --rpc.txfeecap=0, no cap on tx fee
{
    "jsonrpc": "2.0",
    "id": "1",
    "error": {
        "code": -32603,
        "message": "tx fee (1.11 ether) exceeds the configured cap (1.00 ether)"
    }
}

@rrrengineer rrrengineer changed the title WIP: adding cli --rpc.txfeecap flag adding cli --rpc.txfeecap flag Apr 11, 2025
@rrrengineer rrrengineer requested a review from mattsse April 11, 2025 04:57
@rrrengineer rrrengineer changed the title adding cli --rpc.txfeecap flag feat: adding cli --rpc.txfeecap flag Apr 11, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, love the tests, more pedantic unit nits

and a question regarding the actual check

@rrrengineer rrrengineer requested review from mattsse and 0xtinkle April 11, 2025 15:29
@rrrengineer
Copy link
Contributor Author

@mattsse Please take a look at the changes and let me know if more adjustments are needed.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

more nits

@rrrengineer rrrengineer requested a review from mattsse April 15, 2025 12:53
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ty

@mattsse mattsse added this pull request to the merge queue Apr 15, 2025
Merged via the queue into paradigmxyz:main with commit 4850bd5 Apr 15, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 15, 2025
07Vaishnavi-Singh pushed a commit to 07Vaishnavi-Singh/reth that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-tx-pool Related to the transaction mempool
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants