-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: adding cli --rpc.txfeecap flag #15654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding cli --rpc.txfeecap flag #15654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, great start, some suggestions
Implementation tested with op-reth full node
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, love the tests, more pedantic unit nits
and a question regarding the actual check
@mattsse Please take a look at the changes and let me know if more adjustments are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty,
more nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ty
Co-authored-by: Matthias Seitz <[email protected]>
Working on #15618