feat: add config for reserved CPU cores Resolves paradigmxyz/reth#15633 #15710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunter-Plus
requested review from
mattsse,
Rjected,
onbjerg,
klkvr,
rkrasiuk,
fgimenez and
gakonst
as code owners
You can put this is in the PR description instead of the title btw (Just a passing comment, have not checked the PR) |
emhane
added
A-rpc
mattsse
requested changes
Apr 14, 2025
mattsse
approved these changes
Apr 15, 2025
07Vaishnavi-Singh
pushed a commit
to 07Vaishnavi-Singh/reth
that referenced
this pull request
May 3, 2025
…aradigmxyz#15710) Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear cores,
This is my first PR! Thanks for your time in reviewing and I will be happy to do any further optimization for this little adding.
I also noticed that RPC server also has a fixed number 2 for reserving CPU cores.
reth/crates/rpc/rpc-server-types/src/constants.rs
Line 26 in 5a1cdfd
As per my user experience, the Sender Recovery stage was the only one with performance issue when there were a lot of syncing to do. The best way to prevent any performance concern should be adding a global configuration for the reserved CPU cores. However, in respect to the modular design, I decided not to touch the RPC part as it had never ate too much CPU.