Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make import work in node 13 ESM #188

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

benbucksch
Copy link
Contributor

Fixes issue #187 error: "Cannot find main entry point" in package.json

@benbucksch
Copy link
Contributor Author

After merging this, could you please update the npm package?

@mathiasrw
Copy link
Member

Thank you!

@mathiasrw mathiasrw merged commit e913418 into parallel-js:master May 14, 2020
@benbucksch
Copy link
Contributor Author

benbucksch commented May 14, 2020

@mathiasrw : Thank you for merging it so quickly!

Thank you also for your thumbs-up on the npm package update. That would be very useful.

@mathiasrw
Copy link
Member

Ill see what I can do. Not sure I have access more.

@MaXFalstein
Copy link
Member

MaXFalstein commented May 18, 2020

Ill see what I can do. Not sure I have access more.

I do not remember any of us ever having NPM access.
We do have GitHub package and release access.

@mathiasrw
Copy link
Member

mathiasrw commented May 18, 2020

Nope - I dont have access any more. I have a feeling that I got that some years ago - but I might be mistaken. Last update was 6 years ago. Time for an npm name change?

@benbucksch
Copy link
Contributor Author

benbucksch commented May 18, 2020

$ npm owner ls paralleljs
asavitzky <adam.savitzky (at) gmail.com>

@MaXFalstein
Copy link
Member

I would prefer not to have to change the NPM name.
@mathiasrw, who has had contact wih Adam?
I do not think I have. Everything has been through @amilajack or you.

@benbucksch
Copy link
Contributor Author

Enlightening (less bureaucratic than I thought!): https://docs.npmjs.com/using-npm/disputes.html

@mathiasrw
Copy link
Member

@benbucksch There is no dispute. The repo is adams, the npm is adams. A dispute would be if we insists that we have the right to the npm name. We dont. We contribute with the rights as the originator see fit.

@benbucksch
Copy link
Contributor Author

benbucksch commented May 19, 2020

Mathias, yes, of course. The title of the document is a bit misleading, but it's also for an unresponsive maintainer. (6 years without releases is something!)

Did you contact adams by email? Will he make the release? If yes, no problem, all good. If no, you can make releases again via this process.

@mathiasrw
Copy link
Member

@benbucksch Ok. You are right. I sent him an email cc npm.

@mathiasrw
Copy link
Member

image

@MaXFalstein
Copy link
Member

Incredible response time; great support so far 👍🏼

@mathiasrw
Copy link
Member

Merged and pushed to npm as version 1.0.0

@benbucksch
Copy link
Contributor Author

That's great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants