Add more log for push #249
Conversation
wangmengyan95
commented
Nov 13, 2015
wangmengyan95
commented
- Add log when we recive deviceToken from GCM.
- Add log when developers try to use PPNS but miss something.
- Add log to recommend developers to use GCM
|
@hallucinogen it would be great if you can also tay a look. |
|
By analyzing the blame information on this pull request, we identified @grantland and @wangmengyan95 to be potential reviewers. |
| @@ -260,6 +261,40 @@ public static PushType getPushType() { | |||
| PLog.e(TAG, "Cannot use GCM for push because the app manifest is missing some " + | |||
| "required declarations. Please " + getGcmManifestMessage()); | |||
| } | |||
| } else if (hasAnyPPNSSpecificDeclaration) { | |||
There was a problem hiding this comment.
I think we clean this up on purpose. We used to have this flag. @grantland
wangmengyan95
force-pushed
the
wangmengyan.update_detail_log_about_push
branch
from
5feac86 to
bfd9651
Compare
|
@wangmengyan95 updated the pull request. |
| @@ -138,7 +138,9 @@ public void onReceive(Context context, Intent intent) { | |||
| protected void onPushReceive(Context context, Intent intent) { | |||
| JSONObject pushData = null; | |||
| try { | |||
| pushData = new JSONObject(intent.getStringExtra(KEY_PUSH_DATA)); | |||
| String pushDataStr = intent.getStringExtra(KEY_PUSH_DATA); | |||
| PLog.v(TAG, pushDataStr); | |||
There was a problem hiding this comment.
Not sure whether this introduces too much overhead for production, but for debugging purpose, I think this is necessary since there is no reliable way for us to tell whether a device has received a push notification or not.
There was a problem hiding this comment.
Should be fine. We also did something similar on .NET.
There was a problem hiding this comment.
"Received push data: " + pushDataStr
|
yay! |
wangmengyan95
force-pushed
the
wangmengyan.update_detail_log_about_push
branch
from
bfd9651 to
e8fc559
Compare
|
@wangmengyan95 updated the pull request. |
|
LGTM |
…log_about_push Add more log for push
|
@wangmengyan95 updated the pull request. |
