Implement copying #311
Merged
Implement copying #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grantland
commented
Dec 18, 2015
grantland
commented
- ParseQuery
- ParseACL
- ParseGeoPoint
- ParsePush
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
|
@grantland updated the pull request. |
1 similar comment
|
@grantland updated the pull request. |
|
@grantland updated the pull request. |
| * @param acl | ||
| * The acl to copy. | ||
| */ | ||
| public ParseACL(ParseACL acl) { |
There was a problem hiding this comment.
Since this is a public API, do we need to add null checking here?
There was a problem hiding this comment.
It implicitly NPE on the next line, which I think is fine since Java APIs work similarly: https://android.googlesource.com/platform/libcore/+/refs/heads/master/luni/src/main/java/java/util/HashMap.java#194
|
one question, others LGTM! |
* ParseQuery * ParseGeoPoint * ParseACL * ParsePush
grantland
force-pushed
the
grantland.copy
branch
from
5589f17 to
a1ab2eb
Compare
grantland
added a commit
that referenced
this pull request
Dec 21, 2015
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.