-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default parse server url #356
Conversation
By analyzing the blame information on this pull request, we identified @richardjrossiii, @grantland and @wangmengyan95 to be potential reviewers. |
Fixes #352 |
@richardjrossiii Does this comply with the batch issue raised in #330? |
@grantland Yes, URLs are constructed identically in batch vs normal creation. |
@grantland @richardjrossiii any other opinions about this fix? |
As long as everything works, I think it's fine. The original concern with trailing slashes was that it would cause a double slash which would mean root:
Are you sure this scenario won't be an issue? |
@grantland, just tested
The finial url is |
Awesome, LGTM |
…_bug Fix default parse server url
Hey guys, we may want to re-investigate this. I just tested (locally, and here), it definitely converts a double slash into a path for root. |
Yep, I do a more through test here. |
Discussed in person. The original concern comes from the fact that the paths in iOS/.NET are defined with a leading |
@wangmengyan95 updated the pull request. |
We need to add additional
/
at the end of our default server URL address. Otherwise, when we usenew URL(server, httpPath)
to build the URL here, the/1
will be ignored.cc @richardjrossiii