Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the right builder #637

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Use the right builder #637

merged 1 commit into from
Apr 18, 2017

Conversation

Jawnnypoo
Copy link
Member

Fixes #636

@codecov
Copy link

codecov bot commented Apr 18, 2017

Codecov Report

Merging #637 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #637      +/-   ##
===========================================
- Coverage     50.93%   50.9%   -0.03%     
+ Complexity     1525    1524       -1     
===========================================
  Files           127     127              
  Lines          9727    9727              
  Branches       1313    1313              
===========================================
- Hits           4954    4952       -2     
- Misses         4372    4373       +1     
- Partials        401     402       +1
Impacted Files Coverage Δ Complexity Δ
Parse/src/main/java/com/parse/ParsePlugins.java 43.75% <100%> (ø) 12 <0> (ø) ⬇️
Parse/src/main/java/com/parse/ParseHttpClient.java 70.21% <0%> (-2.13%) 17% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a79b6...e875fe4. Read the comment docs.

@Jawnnypoo
Copy link
Member Author

Pulled this in locally using jitpack and I can confirm this fixes it. @rogerhu Please take a look when you get a moment.

@rogerhu rogerhu merged commit 638f03c into parse-community:master Apr 18, 2017
@rogerhu
Copy link
Contributor

rogerhu commented Apr 18, 2017

Do we need the same for fileClient?

@Jawnnypoo
Copy link
Member Author

fileClient is actually not including the interceptor that the restClient is, which means it is not including the app id, client key etc. This was the case with 1.14.1 https://github.com/parse-community/Parse-SDK-Android/blob/1.14.1/Parse/src/main/java/com/parse/ParseFileController.java I guess file operations do not require those headers?

@rogerhu
Copy link
Contributor

rogerhu commented Apr 18, 2017

Great. I've released 1.15.1 to Maven (should take a few hours to sync). In the meantime, I think you either need a custom OkHttpClient or simply use 1.14.1. Thanks for the quick verification!

@Jawnnypoo Jawnnypoo deleted the okhttp-builder-hotfix branch April 18, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants