Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused or unneeded proguard rules #649

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Remove some unused or unneeded proguard rules #649

merged 1 commit into from
Apr 30, 2017

Conversation

Jawnnypoo
Copy link
Member

Turns out we don't need a few of these as they were for when we were using a deprecated Notification class from API 23, and the SSLCertificateSocketFactory on other implementations of the Http Client.

In addition, I am removing the lines that keep source files and line numbers, as this should be decided on/configured by the end consumer, as they might not actually want those things to be kept in their end APK.

@codecov
Copy link

codecov bot commented Apr 29, 2017

Codecov Report

Merging #649 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #649      +/-   ##
============================================
- Coverage     52.88%   52.86%   -0.02%     
  Complexity     1676     1676              
============================================
  Files           131      131              
  Lines         10146    10146              
  Branches       1408     1408              
============================================
- Hits           5366     5364       -2     
- Misses         4338     4339       +1     
- Partials        442      443       +1
Impacted Files Coverage Δ Complexity Δ
...se/src/main/java/com/parse/ParseKeyValueCache.java 45% <0%> (-2%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032054b...cc2bdd7. Read the comment docs.

@rogerhu
Copy link
Contributor

rogerhu commented Apr 30, 2017

rebase

@rogerhu rogerhu merged commit 803d260 into parse-community:master Apr 30, 2017
@Jawnnypoo Jawnnypoo deleted the proguard-update branch May 17, 2017 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants