Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseQueryAdapter for View Pager #98

Closed
wants to merge 6 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ParseUI-Widget/build.gradle
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@ group = 'com.parse'

dependencies {
compile 'com.parse:parse-android:1.10.3'
compile 'com.android.support:support-v13:21.0.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you choose v13?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the projects I was working on were using native Fragments, so I went with the v13 support library. However, I can easily make changes to this to use the v4 support library, or I can have 2 different versions of this adapter to ease development for those who have implemented v4 or native Fragments.


androidTestCompile 'com.google.dexmaker:dexmaker:1.2'
androidTestCompile 'com.google.dexmaker:dexmaker-mockito:1.2'
@@ -39,7 +40,7 @@ android {
buildToolsVersion "21.1.1"

defaultConfig {
minSdkVersion 9
minSdkVersion 13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanleyw @grantland Thoughts on this? Right now for Parse, the minSdkVersion is 9. What is our standard to deprecate a version?

targetSdkVersion 21
versionName project.version
versionCode 1
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package com.parse;

/**
* Modified by Pablo Baxter (Github: soaboz)
*/
public class ParseQueryPagerAdapterOfflineEnabledTest extends ParseQueryPagerAdapterTest {
@Override
public void setUp() throws Exception {
super.setUp();
Parse.enableLocalDatastore(null);
}

@Override
public void tearDown() throws Exception {
Parse.disableLocalDatastore();
super.tearDown();
}

@Override
public void testLoadObjectsWithCacheThenNetworkQueryAndPagination() throws Exception {
// Do nothing, there is no cache policy when LDS is enabled.
}
}
Loading