Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split dependency-groups in sections #59

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

laenan8466
Copy link
Contributor

@laenan8466 laenan8466 commented Feb 27, 2025

Change

This implements development-dependencies as groups, to enable using only part of the dependencies, e.g. for deploy or ci.

For this we add the groups maintain, ci and docs are added. Documentation is adapted as needed.

Reference - Question #58

Open Question

Group names

Think if you want to keep these names. For uv the default name is dev and there is a flag for this name.

Options:

  • One could rename the maintain or ci group to dev.
  • Maybe it is an option to combine ci and maintain to dev.

Things to consider:

  • What usecases are there, where only part of the dependencies are needed? I can think of: docs deployment, running ci-tests, release-pipeline, ...

Add --all-groups

Should the different uv sync calls have the --all-groups flag? Normally this should be covered by the default-groups, but if users add more groups, these will not be default, e.g. for setup. That can be good and bad.

Dependency groups are split in sections maintain, ci & docs. This allows selective installation (e.g. for deployment or docs).

Discussion pawamoy#58: pawamoy#58
Change docs to usage of [dependency-groups].

Discussion pawamoy#58: pawamoy#58
@laenan8466 laenan8466 marked this pull request as ready for review February 27, 2025 21:15
@laenan8466 laenan8466 marked this pull request as draft February 27, 2025 21:15
@laenan8466 laenan8466 marked this pull request as ready for review February 27, 2025 21:16
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just an unimportant style suggestion 🙂

@pawamoy pawamoy merged commit bae928e into pawamoy:main Feb 27, 2025
18 of 21 checks passed
@pawamoy
Copy link
Owner

pawamoy commented Feb 27, 2025

I don't expect to use uv flags to select/unselect specific groups locally. In CI we could definitely unselect groups to install only what's necessary depending on the job. We can do that in another PR 🙂 Also yeah we could probably rename maintain to dev, though that's not super important.

@laenan8466 laenan8466 deleted the split-dependency-groups branch February 27, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants