fix: field appending on duplicate should ignore non string values

packages/payload/src/fields/setDefaultBeforeDuplicate.ts

@@ -1,13 +1,14 @@
 // @ts-strict-ignore
 // default beforeDuplicate hook for required and unique fields
 import { type FieldAffectingData, type FieldHook, fieldShouldBeLocalized } from './config/types.js'
+import { handleUniqueFields } from './utilities/handleUniqueFields.ts.js'
 
-const unique: FieldHook = ({ value }) => (typeof value === 'string' ? `${value} - Copy` : undefined)
+const hasValue = (value) => typeof value === 'string' && value.trim() !== ''
+const unique: FieldHook = ({ value }) => (hasValue(value) ? `${value} - Copy` : undefined)
 const localizedUnique: FieldHook = ({ req, value }) =>
-  value ? `${value} - ${req?.t('general:copy') ?? 'Copy'}` : undefined
-const uniqueRequired: FieldHook = ({ value }) => `${value} - Copy`
-const localizedUniqueRequired: FieldHook = ({ req, value }) =>
-  `${value} - ${req?.t('general:copy') ?? 'Copy'}`
+  hasValue(value) ? `${value} - ${req?.t('general:copy') ?? 'Copy'}` : undefined
+const numberUnique: FieldHook = ({ value }) => (value ? `${value + 1}` : undefined)
+const resetUnique: FieldHook = () => undefined
 
 export const setDefaultBeforeDuplicate = (
   field: FieldAffectingData,
@@ -18,16 +19,18 @@ export const setDefaultBeforeDuplicate = (
     (!field.hooks?.beforeDuplicate ||
       (Array.isArray(field.hooks.beforeDuplicate) && field.hooks.beforeDuplicate.length === 0))
   ) {
-    if ((field.type === 'text' || field.type === 'textarea') && field.required && field.unique) {
-      field.hooks.beforeDuplicate = [
-        fieldShouldBeLocalized({ field, parentIsLocalized })
-          ? localizedUniqueRequired
-          : uniqueRequired,
-      ]
-    } else if (field.unique) {
-      field.hooks.beforeDuplicate = [
-        fieldShouldBeLocalized({ field, parentIsLocalized }) ? localizedUnique : unique,
-      ]
+    if (field.unique) {
+      const updateStrategy = handleUniqueFields(field.type)
+
+      const strategyHooks = {
+        append: [fieldShouldBeLocalized({ field, parentIsLocalized }) ? localizedUnique : unique],
+        numericallyAppend: [numberUnique],
+        undefined: [resetUnique],
+      }
+
+      if (strategyHooks[updateStrategy]) {
+        field.hooks.beforeDuplicate = strategyHooks[updateStrategy]
+      }
     }
   }
 }

packages/payload/src/fields/utilities/handleUniqueFields.ts.ts

@@ -0,0 +1,29 @@
+// Fields that can have unique values:
+// Json - can append
+// Code - can append
+// Email - cant do anything, return undefined
+// Number - can append with number + 1
+// Point - cant do anything, return undefined
+// Relationship - cant do anything, return undefined
+// Select - cant do anything, return undefined
+// Text - can append
+// Textarea - can append
+// Upload - cant do anything, return undefined
+
+type updateOptions = 'append' | 'numericallyAppend' | 'undefined'
+
+const updateStrategies: Record<updateOptions, Set<string>> = {
+  append: new Set(['code', 'json', 'text', 'textarea']),
+  numericallyAppend: new Set(['number']),
+  undefined: new Set(['email', 'point', 'relationship', 'select', 'upload']),
+}
+
+export const handleUniqueFields = (fieldType: string): updateOptions => {
+  if (updateStrategies.append.has(fieldType)) {
+    return 'append'
+  }
+  if (updateStrategies.numericallyAppend.has(fieldType)) {
+    return 'numericallyAppend'
+  }
+  return 'undefined'
+}