fix(plugin-cloud-storage): file sizes use correct mime type #11633
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bug was caused by usign the main file mimeType instead of the resized file mime types. often, the resized file will have a different mime type (ex: converting all files to jpg)
|
I really don't have any idea why that test failed... doesn't seem to have anything to do with uploads AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #7575
Why?
The bug was caused by using the upload file mimeType instead of the resized file mime types.
Often, the resized file will have a different mime type (ex: converting all files to jpg) so this is incorrect.
How?
Use the resizedFile mime type with the upload file mimeType as a backup
I'm unsure when/why the resized files wouldn't have a mime type, but the base file mime type is a sensible backup option.