Bugfix/issue-140 broken record and verify tasks on windows

[mariuszmarzec]

📌 References

• Issue: Closes Can not pull record screenshots from the phone to the project on Windows 10 #140

🎩 What is the goal?

Verify and record tasks are broken on Windows due to hardcoded unix tmp dir and unix style metadata path returned by Config.metadataFileName method.

How is it being implemented?

Replaced system tmp dir with tmp dir from build directory.

How can it be tested?

Added unit tests, tested locally on Windows

• Use case 1: Unit tests passed
  • Step 1 gradlew core:test

[mariuszmarzec]

@pedrovgs Ready to check :)

[pedrovgs]

Hey @mariuszmarzec thank you so much for your contribution. I've merged a previous one that generates conflicts with yours because now the folder path is computed inside a data class improving a lot the quality of the code. Could you please update this PR? You can even move the OS param to the new ShotFolder data class and implement the fix there. This would simplify your changes as well.

[mariuszmarzec]

@pedrovgs I changed slightly approach to fix this issue.
Fact one, after merged PR with shot folder, it is not necessary to:

Changed metadataFileName to metadataFilePath. Added new metadataFileName which returns only metadata.xml file name.

And second thing. After some thoughts i decided to not introduce dependency on system. Instead of i suggest to not use tmp system dir, we could use `build/tmp' path.

[pedrovgs]

The code looks awesome now. Thank you so much @mariuszmarzec. I'm wondering if we could configure CI to check if the windows build is working automatically for us. I'm going to ask for a second check on the original issue too before merging the PR and releasing a new version 😃

[pedrovgs]

@mariuszmarzec can you fix the code formatting? You can do it just running ./gradlew scalaFmtAll and then commit the changes 😃 Thank you!

[mariuszmarzec]

@pedrovgs Now should be fine, i tried ./gradlew scalaFmtAll before but it made mess with changing LF into CRLF (working on Windows 🤷 ) and i decided to reformat files in different way. This time i better checked what reallly need to be changed with scalaFmt 😄

[mariuszmarzec]

@pedrovgs I have checked locally and only first one is failing on my machine and it is connected with keyboard. Seems to be not connected with changes.

12-08 13:43:53.492 20316 20341 E TestRunner: failed: cursorIsNotVisibleOnScreenshot(com.karumi.ui.view.CursorActivityTest)
12-08 13:43:53.492 20316 20341 E TestRunner: ----- begin exception -----
12-08 13:43:53.492 20316 20341 E TestRunner: java.lang.IllegalStateException: We couldn't close they keyboard after 5 retries.
12-08 13:43:53.492 20316 20341 E TestRunner: at com.karumi.shot.KeyboardCloser$DefaultImpls.recursiveCloseKeyboardAndWaitUntilIsNotVisible(KeyboardCloser.kt:30)

Looks like using Espresso.closeSoftKeyboard() is fixing this issue. After fixing it locally this ./gradlew executeScreenshotTests --stacktrace command for shot-consumer project is still failing on my Windows due to not fixed tmp path in version 5.12.0 used in project. So i'm not able to fully verify.