Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-710: Make spec.backups.pgbackrest optional #1021

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

K8SPG-710: Make spec.backups.pgbackrest optional #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e1aee
K8SPG-710: Make spec.backups.pgbackrest optional
egegunes Jan 24, 2025
eed29e6
make spec.backups optional too
egegunes Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/crd/crunchy/generated/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19709,7 +19709,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
3 changes: 0 additions & 3 deletions build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4987,8 +4987,6 @@ spec:
trackLatestRestorableTime:
description: Enable tracking latest restorable time
type: boolean
required:
- pgbackrest
type: object
crVersion:
description: |-
Expand Down Expand Up @@ -17503,7 +17501,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
3 changes: 0 additions & 3 deletions config/crd/bases/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5393,8 +5393,6 @@ spec:
trackLatestRestorableTime:
description: Enable tracking latest restorable time
type: boolean
required:
- pgbackrest
type: object
crVersion:
description: |-
Expand Down Expand Up @@ -17909,7 +17907,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
1 change: 0 additions & 1 deletion config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19607,7 +19607,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
4 changes: 0 additions & 4 deletions deploy/bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5686,8 +5686,6 @@ spec:
trackLatestRestorableTime:
description: Enable tracking latest restorable time
type: boolean
required:
- pgbackrest
type: object
crVersion:
description: |-
Expand Down Expand Up @@ -18202,7 +18200,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down Expand Up @@ -45292,7 +45289,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
4 changes: 0 additions & 4 deletions deploy/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5686,8 +5686,6 @@ spec:
trackLatestRestorableTime:
description: Enable tracking latest restorable time
type: boolean
required:
- pgbackrest
type: object
crVersion:
description: |-
Expand Down Expand Up @@ -18202,7 +18200,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down Expand Up @@ -45292,7 +45289,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
4 changes: 0 additions & 4 deletions deploy/cw-bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5686,8 +5686,6 @@ spec:
trackLatestRestorableTime:
description: Enable tracking latest restorable time
type: boolean
required:
- pgbackrest
type: object
crVersion:
description: |-
Expand Down Expand Up @@ -18202,7 +18200,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down Expand Up @@ -45292,7 +45289,6 @@ spec:
- name
x-kubernetes-list-type: map
required:
- backups
- instances
- postgresVersion
type: object
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ type PerconaPGClusterSpec struct {
Proxy *PGProxySpec `json:"proxy,omitempty"`

// PostgreSQL backup configuration
// +kubebuilder:validation:Required
// +operator-sdk:csv:customresourcedefinitions:type=spec
// +optional
Backups Backups `json:"backups"`

// The specification of PMM sidecars.
Expand Down Expand Up @@ -436,7 +436,7 @@ type PerconaPGClusterStatus struct {

type Backups struct {
// pgBackRest archive configuration
// +kubebuilder:validation:Required
// +optional
PGBackRest PGBackRestArchive `json:"pgbackrest"`

// Enable tracking latest restorable time
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type PostgresClusterSpec struct {
DataSource *DataSource `json:"dataSource,omitempty"`

// PostgreSQL backup configuration
// +kubebuilder:validation:Required
// +optional
Backups Backups `json:"backups"`

// The secret containing the root CA certificate and key for
Expand Down
Loading