K8SPG-571 grant user access to public schema #1097
Draft
+243
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkech
reviewed
Mar 21, 2025
internal/postgres/users.go
Outdated
Comment on lines
262
to
264
| var err error | ||
| var stdout string | ||
| var stderr string |
There was a problem hiding this comment.
Why did these variables need to be defined here? We can simply do stdout, stderr, err := exec..., right?
internal/postgres/users.go
Outdated
Comment on lines
173
to
174
| for i := range users { | ||
| user := users[i] |
There was a problem hiding this comment.
We can use the way to iterate on elements of an array without using indexes:
for _, user := range users { ...
Comment on lines
65
to
66
| // Grant a specific user access to the public schema in every database where they already have permissions. | ||
| // +optional |
There was a problem hiding this comment.
I recommend this comment with a pointer to the databases field to increase clarity:
// Grant the user access to the public schema in each database listed under `databases`.
// +optional
|
|
||
| // Grant a specific user access to the public schema in every database where they already have permissions. | ||
| // +optional | ||
| GrantPublicSchemaAccess *bool `json:"grantPublicSchemaAccess,omitempty"` |
laudares
reviewed
Mar 21, 2025
hors
reviewed
Mar 21, 2025
| @@ -19655,6 +19655,10 @@ spec: | |||
| type: string | |||
| type: array | |||
| x-kubernetes-list-type: set | |||
| grantPublicSchemaAccess: | |||
There was a problem hiding this comment.
@nmarukovich please confirm this name with our PM
PeterSzcz
reviewed
Mar 21, 2025
commit: 0819c1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
By default, when user is created for a specific database, it only has access to a schema matching its username. However, in some cases, granting access to the public schema may also be necessary. To accommodate this need, the option to enable public schema access for users was added.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability