K8SPS-61: Rename CRD to PerconaServerMySQL #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tplavcic
reviewed
Jan 21, 2022
There was a problem hiding this comment.
In rbac.yaml our roles/rolesbindings are called like:
name: percona-server-for-mysql-operator-leader-election-role
name: percona-server-for-mysql-operator-role
name: percona-server-for-mysql-operator-leader-election-rolebinding
name: percona-server-for-mysql-operator-leader-election-role
name: percona-server-for-mysql-operator-rolebinding
so they have suffix -role and -rolebinding which I don't see in PSMDB/PXC operators.
Maybe consider making it the same.
https://github.com/percona/percona-server-mysql-operator/blob/main/deploy/rbac.yaml#L9
https://github.com/percona/percona-xtradb-cluster-operator/blob/main/deploy/rbac.yaml
https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/rbac.yaml
We're also changing the api version (from v2 to v1alpha1) of our CRD. It may break the new deployments if the old CRDs installed in the cluster. In case of any errors, delete the old ones: ``` kubectl delete crd perconaserverformysqls.ps.percona.com kubectl delete crd perconaserverformysqlbackups.ps.percona.com kubectl delete crd perconaserverformysqlrestores.ps.percona.com ```
egegunes
changed the title
commit: 8ab54f7 |
tplavcic
approved these changes
Jan 24, 2022
spron-in
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're also changing the api version (from v2 to v1alpha1) of our CRD. It
may break the new deployments if the old CRDs installed in the cluster.
In case of any errors, delete the old ones: